[MRG] Fix LassoCV cross validation split() call #8973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This test failed, but it seems is not related to this PR. |
agramfort
reviewed
Jun 2, 2017
|
|
||
| pipe = make_pipeline( | ||
| StandardScaler(), | ||
| LassoCV(cv=KFold(n_splits=5)) |
There was a problem hiding this comment.
this test would fail on master?
There was a problem hiding this comment.
it should be StratifiedKFold...
There was a problem hiding this comment.
Sorry, @raghavrv! My bad at pasting.
Fixed that, although I could not run tests locally today.
raghavrv
suggested changes
Jun 2, 2017
|
|
||
| pipe = make_pipeline( | ||
| StandardScaler(), | ||
| LassoCV(cv=KFold(n_splits=5)) |
There was a problem hiding this comment.
it should be StratifiedKFold...
| def test_lasso_cv_with_some_model_selection(): | ||
| from sklearn.pipeline import make_pipeline | ||
| from sklearn.preprocessing import StandardScaler | ||
| from sklearn.model_selection import KFold |
|
LGTM, thanks |
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
* Fixing cross validation split call in LassoCV * Non-regression test for LassoCV cv.split check * Fix typo KFold->StratifiedKFold
|
Thank you for your help! Learnt a lot doing this, and happy for detecting the problem issue 8971 is going to solve. |
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
* Fixing cross validation split call in LassoCV * Non-regression test for LassoCV cv.split check * Fix typo KFold->StratifiedKFold
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
* Fixing cross validation split call in LassoCV * Non-regression test for LassoCV cv.split check * Fix typo KFold->StratifiedKFold
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
* Fixing cross validation split call in LassoCV * Non-regression test for LassoCV cv.split check * Fix typo KFold->StratifiedKFold
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* Fixing cross validation split call in LassoCV * Non-regression test for LassoCV cv.split check * Fix typo KFold->StratifiedKFold
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
* Fixing cross validation split call in LassoCV * Non-regression test for LassoCV cv.split check * Fix typo KFold->StratifiedKFold
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
* Fixing cross validation split call in LassoCV * Non-regression test for LassoCV cv.split check * Fix typo KFold->StratifiedKFold
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
* Fixing cross validation split call in LassoCV * Non-regression test for LassoCV cv.split check * Fix typo KFold->StratifiedKFold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #8426
What does this implement/fix? Explain your changes.
Added the missing
yparameter that was causing the errorTypeError: split() missing 1 required positional argument: 'y', and its non-regression test.Any other comments?
Will be positively influenced by issue #8971.